Wireshark-commits: [Wireshark-commits] master 5727ebe: extcap: Implement QT extcap options
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Tue, 5 May 2015 09:35:16 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=5727ebe6890bc263b90b3a77435b7aa7ae0ca411
Submitter: Pascal Quantin (pascal.quantin@xxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

5727ebe by Roland Knall (roland.knall@xxxxxxxxxxxxxxxxx):

    extcap: Implement QT extcap options
    
     Implementing a button in the interface list, to bring up
     the extcap options dialog, as well as a dialog, which will
     be generated depending on the selected extcap options.
    
    Change-Id: I1733dc6a8c1a121089a9c353aff10bc4a53e86de
    Reviewed-on: https://code.wireshark.org/review/8224
    Petri-Dish: Michal Labedzki <michal.labedzki@xxxxxxxxx>
    Reviewed-by: Roland Knall <rknall@xxxxxxxxx>
    Reviewed-by: Pascal Quantin <pascal.quantin@xxxxxxxxx>
    

Actions performed:

    from  cdaad86   Try to please both GCC (the compiler, not me) and clang.
    adds  5727ebe   extcap: Implement QT extcap options


Summary of changes:
 extcap.c                                           |   26 +
 extcap.h                                           |   11 +
 extcap_parser.c                                    |    4 +-
 extcap_parser.h                                    |   21 +-
 ui/gtk/extcap_gtk.c                                |    4 -
 ui/help_url.c                                      |    3 +
 ui/help_url.h                                      |    3 +
 ui/qt/CMakeLists.txt                               |   25 +
 ui/qt/Makefile.am                                  |    2 +
 ui/qt/Makefile.common                              |    8 +
 ui/qt/Wireshark.pro                                |    7 +
 ui/qt/extcap_argument.cpp                          |  657 ++++++++++++++++++++
 ui/qt/extcap_argument.h                            |  117 ++++
 ui/qt/extcap_argument_file.cpp                     |  111 ++++
 ...lter_syntax_worker.h => extcap_argument_file.h} |   37 +-
 ui/qt/extcap_options_dialog.cpp                    |  243 ++++++++
 .../{file_set_dialog.h => extcap_options_dialog.h} |   60 +-
 ui/qt/extcap_options_dialog.ui                     |   34 +
 ui/qt/interface_tree.cpp                           |   84 ++-
 ui/qt/interface_tree.h                             |   12 +
 ui/qt/main_welcome.cpp                             |   23 +
 ui/qt/main_welcome.h                               |    6 +
 ui/qt/main_welcome.ui                              |    3 -
 ui/qt/main_window.cpp                              |    5 +
 ui/qt/main_window.h                                |    5 +
 ui/qt/main_window_slots.cpp                        |   27 +
 26 files changed, 1460 insertions(+), 78 deletions(-)
 create mode 100644 ui/qt/extcap_argument.cpp
 create mode 100644 ui/qt/extcap_argument.h
 create mode 100644 ui/qt/extcap_argument_file.cpp
 copy ui/qt/{capture_filter_syntax_worker.h => extcap_argument_file.h} (66%)
 create mode 100644 ui/qt/extcap_options_dialog.cpp
 copy ui/qt/{file_set_dialog.h => extcap_options_dialog.h} (55%)
 create mode 100644 ui/qt/extcap_options_dialog.ui