Wireshark-commits: [Wireshark-commits] master 4f95ff8: Expand comments.
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Sat, 2 May 2015 09:22:39 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=4f95ff832e915ab1ea810326e2afa35c5b7beca8
Submitter: Guy Harris (guy@xxxxxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

4f95ff8 by Guy Harris (guy@xxxxxxxxxxxx):

    Expand comments.
    
    Update a URL, and tell The Story About PIM, or, at least, about various
    drafts floating around.  I guess it took a while for the protocol to
    settle down, and a number of things changed significantly between early
    drafts and RFC 2117, including whether the protocol runs atop IGMP or
    directly atop IP.
    
    There doesn't appear to be *any* draft that corresponds to what
    dissect_pimv1() dissects; all have significant differences.
    
    Change-Id: Ia9c80cc384546b0a822a59fef01c1476f95ad8a6
    Reviewed-on: https://code.wireshark.org/review/8269
    Reviewed-by: Guy Harris <guy@xxxxxxxxxxxx>
    

Actions performed:

    from  ecd16b4   Fix checkAPI: Warning: i4b_trace.h has an SVN Id tag. Please remove it!
    adds  4f95ff8   Expand comments.


Summary of changes:
 epan/dissectors/packet-pim.c |   64 ++++++++++++++++++++++++++++++++++++------
 1 file changed, 56 insertions(+), 8 deletions(-)