Wireshark-commits: [Wireshark-commits] master aa3870f: C12.22: check c1222_baseoid_len before doing
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Fri, 1 May 2015 07:59:26 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=aa3870f54d2006237c63cad6e0245cab590b57b5
Submitter: Pascal Quantin (pascal.quantin@xxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

aa3870f by Pascal Quantin (pascal.quantin@xxxxxxxxx):

    C12.22: check c1222_baseoid_len before doing a memcpy
    
    Should fix the following runtime error reported by Joerg:
    ../../asn1/c1222/packet-c1222-template.c:1427:3: runtime error: null pointer passed as argument 1, which is declared to never be null
    ../../asn1/c1222/packet-c1222-template.c:1427:3: runtime error: null pointer passed as argument 2, which is declared to never be null
    
    Change-Id: I2f952815ed81e47b504e6479835a357b7656828e
    Reviewed-on: https://code.wireshark.org/review/8251
    Petri-Dish: Pascal Quantin <pascal.quantin@xxxxxxxxx>
    Tested-by: Petri Dish Buildbot <buildbot-no-reply@xxxxxxxxxxxxx>
    Reviewed-by: Jörg Mayer <jmayer@xxxxxxxxx>
    Reviewed-by: Pascal Quantin <pascal.quantin@xxxxxxxxx>
    

Actions performed:

    from  b849726   Fix some cases where we're shifting a signed 1 left.
    adds  aa3870f   C12.22: check c1222_baseoid_len before doing a memcpy


Summary of changes:
 asn1/c1222/packet-c1222-template.c |   14 ++++++++++----
 epan/dissectors/packet-c1222.c     |   14 ++++++++++----
 2 files changed, 20 insertions(+), 8 deletions(-)