Wireshark-commits: [Wireshark-commits] master f80205e: Make bit masks unsigned.
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Thu, 30 Apr 2015 18:14:42 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=f80205e32fd0d6b0f1003cdebcbcddbac9cfb9b7
Submitter: Guy Harris (guy@xxxxxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

f80205e by Guy Harris (guy@xxxxxxxxxxxx):

    Make bit masks unsigned.
    
    To quote a run-time error reported in
    
    	https://www.wireshark.org/lists/wireshark-dev/201504/msg00084.html
    
    "left shift of 1 by 31 places cannot be represented in type 'int'", so
    use type "unsigned int" instead, by shifting 1U rather than 1 left.
    
    Change-Id: I95cf5ce53aa3b94ccb9f246d31863715bb682409
    Reviewed-on: https://code.wireshark.org/review/8252
    Reviewed-by: Guy Harris <guy@xxxxxxxxxxxx>
    

Actions performed:

    from  e003123   CMake for Windows improvements
    adds  f80205e   Make bit masks unsigned.


Summary of changes:
 epan/proto.c |    8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)