Wireshark-commits: [Wireshark-commits] master 97499c1: Add VALS_EXT_PTR to decorate pointers to val
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Wed, 22 Apr 2015 06:09:06 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=97499c1f255ca21ff1860eb067f4eed84d9882fb
Submitter: Anders Broman (a.broman58@xxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

97499c1 by Jeff Morriss (jeff.morriss.ws@xxxxxxxxx):

    Add VALS_EXT_PTR to decorate pointers to value_string_ext's in hfinfo.
    
    This allows checkAPIs to continue checking the 'convert' field for correctness
    when dissectors use value_string_ext_new() to build their value_string_ext's
    (without resorting to tricks like getting the address of the dereferenced
    pointer).
    
    This will be used to resolve the checkAPIs failure in patch set 3 of
    Ia5c96b1f6f1fe3a9521b3d70142889e3881fae5e .
    
    Change-Id: I700d86b9076f077706d34000f5a6aa5c96351f69
    Reviewed-on: https://code.wireshark.org/review/8162
    Petri-Dish: Jeff Morriss <jeff.morriss.ws@xxxxxxxxx>
    Tested-by: Petri Dish Buildbot <buildbot-no-reply@xxxxxxxxxxxxx>
    Reviewed-by: Anders Broman <a.broman58@xxxxxxxxx>
    

Actions performed:

    from  4461f72   Add special handling of the (derived) AppId AVP type so that we can maintain one (and only one) Application ID list.
    adds  97499c1   Add VALS_EXT_PTR to decorate pointers to value_string_ext's in hfinfo.


Summary of changes:
 epan/proto.h       |    3 +++
 tools/checkAPIs.pl |    2 +-
 2 files changed, 4 insertions(+), 1 deletion(-)