Wireshark-commits: [Wireshark-commits] master 8825b55: giop: fix uninitialized use of request id
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Thu, 16 Apr 2015 22:40:45 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=8825b553038c007bf8cf8f1d53dd62b13b3feb6a
Submitter: Evan Huus (eapache@xxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

8825b55 by Evan Huus (eapache@xxxxxxxxx):

    giop: fix uninitialized use of request id
    
    Move the req_id field to the "message-dependent data" section of the header
    struct, since in the spec I found it is not specified in the common GIOP header
    (even though it appears to be present in all message types). Regardless, this
    better reflects the fact that it is not initialized by the primary tvb_memcpy,
    only the independent fields are.
    
    Initialize it and use it rather than creating a local for no reason; fixes the
    possibility of using it uninitialized.
    
    Bug: 11123
    Change-Id: I3bae1df5123fbb1f2b86f7c42cee392b5b045c4f
    Reviewed-on: https://code.wireshark.org/review/8087
    Reviewed-by: Evan Huus <eapache@xxxxxxxxx>
    

Actions performed:

    from  32bbe0a   Extcap: fix logically dead code (CID 1232344)
    adds  8825b55   giop: fix uninitialized use of request id


Summary of changes:
 epan/dissectors/packet-giop.c |    5 ++---
 epan/dissectors/packet-giop.h |    2 +-
 2 files changed, 3 insertions(+), 4 deletions(-)