Wireshark-commits: [Wireshark-commits] master-1.10 0e237fe: Fix gsmtap signal and snr.
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Wed, 15 Apr 2015 21:37:09 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=0e237fea46f52bddf9acdaa1f5b33c48090a0355
Submitter: Pascal Quantin (pascal.quantin@xxxxxxxxx)
Changed: branch: master-1.10
Repository: wireshark

Commits:

0e237fe by Anton Thomasson (anton.thomasson@xxxxxxxxxxxx):

    Fix gsmtap signal and snr.
    
    -Correct parsrsing to get correct value (corect position in header).
    -Rename hf_gsmtap_noise_dbm to hf_gsmtap_snr_db to reflect use and name in struct.
    -Change order of decalaration/use of signal and snr to reflect position in struct.
    -Change registered types to signed to reflect possible values and definition in struct.
    
    Change-Id: I748bd19757c0dd87fe4ad0969dfcc8427b908aa2
    Reviewed-on: https://code.wireshark.org/review/8077
    Reviewed-by: Sylvain Munaut <246tnt@xxxxxxxxx>
    Petri-Dish: Pascal Quantin <pascal.quantin@xxxxxxxxx>
    Tested-by: Petri Dish Buildbot <buildbot-no-reply@xxxxxxxxxxxxx>
    Reviewed-by: Pascal Quantin <pascal.quantin@xxxxxxxxx>
    (cherry picked from commit f026088ca9e97ea003baf46801acfb426ea0b494)
    Reviewed-on: https://code.wireshark.org/review/8079
    

Actions performed:

    from  405043e   ZigBee: fix IS_ANALOG_SUBTYPE macro
    adds  0e237fe   Fix gsmtap signal and snr.


Summary of changes:
 epan/dissectors/packet-gsmtap.c |   12 ++++++------
 1 file changed, 6 insertions(+), 6 deletions(-)