Wireshark-commits: [Wireshark-commits] master 7123438: Bluetooth: OBEX: Fix reassemble at transport
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Tue, 14 Apr 2015 05:43:55 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=71234389ea6b28c7b887927ea926318a0bb00779
Submitter: Michal Labedzki (michal.labedzki@xxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

7123438 by Michal Labedzki (michal.labedzki@xxxxxxxxx):

    Bluetooth: OBEX: Fix reassemble at transport layer
    
    Transport layer is RFCOMM. OBEX packet may be fragmented over RFCOMM.
    If so then (Opcode + Final flag + ) Packet Length determines packet length,
    but whole OBEX packet will be framented over parts/packet that first packet
    has Packet Length and next packets are sequential parts of whole packet
    (no header, etc.) Reassemble on this level is simple concatenation of all packet
    up to Packet Length. Let threat packet shorted than 3 bytes as bad packet.
    
    There is still no reasssemble on OBEX level (aka Final flag), so content send
    over OBEX (vCards, files, XMLs) is still not reassembled.
    
    Change-Id: I11882eb07480b34d274a4ca6e504e609dcf982c0
    Reviewed-on: https://code.wireshark.org/review/8041
    Reviewed-by: Michal Labedzki <michal.labedzki@xxxxxxxxx>
    

Actions performed:

    from  21757ae   Bluetooth: OBEX: Add request/response tracking
    adds  7123438   Bluetooth: OBEX: Fix reassemble at transport layer


Summary of changes:
 epan/dissectors/packet-btobex.c |  133 +++++++++++++++++++++++----------------
 1 file changed, 79 insertions(+), 54 deletions(-)