Wireshark-commits: [Wireshark-commits] master 5f933e8: Only add flags to CFLAGS_FOR_BUILD if $CC an
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Sun, 12 Apr 2015 04:07:58 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=5f933e85604cc9981954cb821736e0d68d0c4c12
Submitter: Guy Harris (guy@xxxxxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

5f933e8 by Guy Harris (guy@xxxxxxxxxxxx):

    Only add flags to CFLAGS_FOR_BUILD if $CC and $CC_FOR_BUILD are the same.
    
    Otherwise, just because a flag is appropriate for $CC, that doesn't
    necessarily mean it's appropriate for $CFLAGS_FOR_BUILD.
    
    (We don't use CFLAGS_FOR_BUILD for many things, so it's probably not
    worth making a lot of effort to throw all the warning flags into it if
    we're cross-compiling; we *do* throw them in for native compilation,
    which is what most developers use and test with, so that should be
    sufficient to let the warnings catch problems with the build tools we're
    building.)
    
    Change-Id: Iad9d611b4687e9e154f9871f741f3c8f3b307c88
    Reviewed-on: https://code.wireshark.org/review/8026
    Reviewed-by: Guy Harris <guy@xxxxxxxxxxxx>
    

Actions performed:

    from  6c34e9a   Ignore androiddump - it's another build target.
    adds  5f933e8   Only add flags to CFLAGS_FOR_BUILD if $CC and $CC_FOR_BUILD are the same.


Summary of changes:
 acinclude.m4 |   24 ++++++++++++++++--------
 configure.ac |   10 +++++++++-
 2 files changed, 25 insertions(+), 9 deletions(-)