Wireshark-commits: [Wireshark-commits] master ee30955: It's not "Windows vs. (Linux or OS X or Cygw
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Sat, 11 Apr 2015 19:54:25 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=ee309553eb05e89f136d6c5eb6774ecc6a7ebf9a
Submitter: Guy Harris (guy@xxxxxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

ee30955 by Guy Harris (guy@xxxxxxxxxxxx):

    It's not "Windows vs. (Linux or OS X or Cygwin)", it's "Windows vs. UN*X".
    
    Either it's Windows and not Cygwin (__WIN32 suffices for both 32-bit and
    64-bit Windows, and this code is unlikely to work on 16-bit Windows, not
    that much of anybody cares about it any more), or it's UN*X or Windows-
    pretending-to-be-UN*X-with-Cygwin.  That way we don't have to pile on
    new defined(XXX)'s for every UN*X out there.
    
    Change-Id: Ia1df3378a88f2cf8bd1cc8f1a74b51adfe668370
    Reviewed-on: https://code.wireshark.org/review/8016
    Reviewed-by: Guy Harris <guy@xxxxxxxxxxxx>
    

Actions performed:

    from  9fecad7   A temporary variable squelches some warnings.
    adds  ee30955   It's not "Windows vs. (Linux or OS X or Cygwin)", it's "Windows vs. UN*X".


Summary of changes:
 extcap/androiddump.c |    8 +++++---
 1 file changed, 5 insertions(+), 3 deletions(-)