Wireshark-commits: [Wireshark-commits] master-1.12 d96d0d5: Have a common routine for constructing
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Mon, 6 Apr 2015 01:19:46 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=d96d0d5399c90fd25e0c44d5fd8e4fa128f10321
Submitter: Guy Harris (guy@xxxxxxxxxxxx)
Changed: branch: master-1.12
Repository: wireshark

Commits:

d96d0d5 by Guy Harris (guy@xxxxxxxxxxxx):

    Have a common routine for constructing strings listing interfaces.
    
    We have a bunch of duplicated code to make those lists; make a common
    routine for that.  (dumpcap currently doesn't use it, as the routine in
    question uses a routine in libui, which dumpcap doesn't use.  We should
    probably fix that.)
    
    Change-Id: I9058bf3320d420b8713e90743618972da1d1c6ed
    Reviewed-on: https://code.wireshark.org/review/7934
    Reviewed-by: Guy Harris <guy@xxxxxxxxxxxx>
    (cherry picked from commit d4bfa9c43b05ccbdef212f55fb56b73a5033e5f6)
    Reviewed-on: https://code.wireshark.org/review/7935
    

Actions performed:

    from  2f87e4a   Pop the welcome screen message when we close a file.
    adds  d96d0d5   Have a common routine for constructing strings listing interfaces.


Summary of changes:
 capture.c                 |   31 ++--------------------------
 capture_ui_utils.c        |   50 +++++++++++++++++++++++++++++++++++++++++++++
 capture_ui_utils.h        |   17 +++++++++++++++
 tshark.c                  |   27 ++----------------------
 ui/gtk/capture_info_dlg.c |   39 +++--------------------------------
 ui/gtk/main_statusbar.c   |   18 +---------------
 6 files changed, 75 insertions(+), 107 deletions(-)