Wireshark · Wireshark-commits: [Wireshark-commits] master e4da62f: Coverity 1158848, 1158849 (logically dead code)

[Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>]

URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=e4da62fefe4f52cccca28875c0e893e69a184152
Submitter: Martin Kaiser (wireshark@xxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

e4da62f by Martin Kaiser (wireshark@xxxxxxxxx):

    Coverity 1158848, 1158849 (logically dead code)
    
    the option parameter of output_fields_set_option() is always a
    0-terminated string
    therefore, option_value can't possibly be NULL, remove the NULL checks
    
    if someone runs 'tshark ... -E header=', option_value is an empty
    string, bail out in this case, don't parse *option_value and
    *(option_value++) in the switch statements
    
    Change-Id: I734b04aff653e8dbe990f546220595546e7503b0
    Reviewed-on: https://code.wireshark.org/review/7904
    Reviewed-by: Martin Kaiser <wireshark@xxxxxxxxx>
    

Actions performed:

    from  f1803db   Add update-tx tools (Resync translation between repo and Transifex)
    adds  e4da62f   Coverity 1158848, 1158849 (logically dead code)


Summary of changes:
 epan/print.c |   25 ++++++++++++-------------
 1 file changed, 12 insertions(+), 13 deletions(-)