Wireshark · Wireshark-commits: [Wireshark-commits] master e74cb41: Remove proto_tree_add_text from GSM dissectors.

[Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>]

URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=e74cb413b474afd416eb25e30e5572b9e775ed3e
Submitter: Anders Broman (a.broman58@xxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

e74cb41 by Michael Mann (mmann78@xxxxxxxxxxxx):

    Remove proto_tree_add_text from GSM dissectors.
    
    Change-Id: I72a7c1a44bda7755d8b1376dd5e57c46f137ff31
    Reviewed-on: https://code.wireshark.org/review/7870
    Reviewed-by: Michael Mann <mmann78@xxxxxxxxxxxx>
    Petri-Dish: Michael Mann <mmann78@xxxxxxxxxxxx>
    Tested-by: Petri Dish Buildbot <buildbot-no-reply@xxxxxxxxxxxxx>
    Reviewed-by: Anders Broman <a.broman58@xxxxxxxxx>
    

Actions performed:

    from  752f5de   Fix bug #10858. There were several cases where uint32 fields were mistaken for two uint16 fields and three fields were merged into one as an unknown. There was also an unnecessary unknown field on the end that caused a malformed packet exception to occur.
    adds  e74cb41   Remove proto_tree_add_text from GSM dissectors.


Summary of changes:
 epan/dissectors/packet-gsm_a_common.c |  238 ++++++-------
 epan/dissectors/packet-gsm_a_dtap.c   |  324 ++++++++++-------
 epan/dissectors/packet-gsm_a_gm.c     |  623 +++++++++++++++------------------
 3 files changed, 591 insertions(+), 594 deletions(-)