Wireshark-commits: [Wireshark-commits] master 7181ae4: Work around a Linux bonding driver bug (and
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Mon, 30 Mar 2015 19:44:41 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=7181ae471345d4e4e85d5edd5341ff7f156de01d
Submitter: Guy Harris (guy@xxxxxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

7181ae4 by Guy Harris (guy@xxxxxxxxxxxx):

    Work around a Linux bonding driver bug (and the lack of a libpcap workaround).
    
    The bonding driver does not properly handle unknown ioctls; it returns
    ENODEV rather than ENOTSUP, EOPNOTSUPP, ENOTTY, or a "not supported"
    error of that type.  This causes problems detailed in bug 11058.
    
    On Linux, check for bonding devices before checking for monitor-mode
    support.
    
    While we're at it, get rid of a commented-out include of
    CheckCSourceCompiles (it's presumably already been implicitly included
    by other functions that use it).
    
    Bug: 11058
    Change-Id: I13035de0650634c51a52f262829b2b6fb86b39e9
    Reviewed-on: https://code.wireshark.org/review/7856
    Petri-Dish: Guy Harris <guy@xxxxxxxxxxxx>
    Tested-by: Petri Dish Buildbot <buildbot-no-reply@xxxxxxxxxxxxx>
    Reviewed-by: Guy Harris <guy@xxxxxxxxxxxx>
    

Actions performed:

    from  f341fd9   WSP: Fix Dead Store (Dead assignement/Dead increment) warning found by Clang
    adds  7181ae4   Work around a Linux bonding driver bug (and the lack of a libpcap workaround).


Summary of changes:
 ConfigureChecks.cmake |   30 ++++++++++++++++-
 configure.ac          |   11 +++++++
 dumpcap.c             |   85 ++++++++++++++++++++++++++++++++++++++++++++++++-
 3 files changed, 124 insertions(+), 2 deletions(-)