Wireshark-commits: [Wireshark-commits] master a596361: DTLS: use addresses_ports_reassembly_table_f
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Thu, 26 Mar 2015 14:48:59 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=a5963612286c706146d477042b722d34d9ba20d7
Submitter: Anders Broman (a.broman58@xxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

a596361 by Andreas Schultz (aschultz@xxxxxxxxxx):

    DTLS: use addresses_ports_reassembly_table_functions
    
    When capturing two consecutive DTLS session to the same server,
    fragments for the second session report a error:
    
    > [Reassembly error, protocol DTLS: New fragment overlaps old data (retransmission?)]
    
    It turns out that the DTLS dissector uses the addresses_reassembly_table_functions
    which takes only the IP addresses into account and not the ports.
    Changing that to the addresses_ports_reassembly_table_functions
    fixes the bogus error message.
    
    Change-Id: If317314dca4b1d46e802bac54c07c89c7a73e24e
    Reviewed-on: https://code.wireshark.org/review/7824
    Reviewed-by: Alexis La Goutte <alexis.lagoutte@xxxxxxxxx>
    Petri-Dish: Alexis La Goutte <alexis.lagoutte@xxxxxxxxx>
    Tested-by: Petri Dish Buildbot <buildbot-no-reply@xxxxxxxxxxxxx>
    Reviewed-by: Anders Broman <a.broman58@xxxxxxxxx>
    

Actions performed:

    from  680dfc1   CMake cleanup for VS solution
    adds  a596361   DTLS: use addresses_ports_reassembly_table_functions


Summary of changes:
 epan/dissectors/packet-dtls.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)