Wireshark-commits: [Wireshark-commits] master dbef80f: dfilter-test.py: add OOT support and Python
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Wed, 25 Mar 2015 07:15:41 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=dbef80f5c723d63d174f645284dcd06cbddb3a48
Submitter: Anders Broman (a.broman58@xxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

dbef80f by Peter Wu (peter@xxxxxxxxxxxxx):

    dfilter-test.py: add OOT support and Python 3 compat
    
    Support WS_BIN_PATH and SOURCE_DIR (modelled after test/config.sh) to
    support out-of-tree builds (including cmake). Add Python 3 support and
    mention this in the documentation.
    
    Tested with Python 2.7.9, 3.2.6, 3.4.3:
    
        WS_BIN_PATH=/tmp/wsbuild/run SOURCE_DIR=/tmp/wireshark \
            tools/dfilter-test.py testBytesIPv6
    
    (2.7.9 and 3.4.3 were also tested fully, but some cases seem to fail
    even before this patch. 2.5.6 and 2.6.6 do not work because the unittest
    module is outdated.)
    
    Change-Id: I13074579f6f74206edb5cd7be8e7a8406de49c56
    Reviewed-on: https://code.wireshark.org/review/7793
    Reviewed-by: Anders Broman <a.broman58@xxxxxxxxx>
    

Actions performed:

    from  1ba4191   indexcap.py: fix tmpdir handling, python 3 compat
    adds  dbef80f   dfilter-test.py: add OOT support and Python 3 compat


Summary of changes:
 doc/README.display_filter |    2 +-
 tools/dftestlib/dftest.py |   10 +++++-----
 tools/dftestlib/util.py   |   12 +++++++-----
 3 files changed, 13 insertions(+), 11 deletions(-)