Wireshark · Wireshark-commits: [Wireshark-commits] master 77bc38e: Clean up handling of buffer size.

[Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>]

URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=77bc38e498b169065909f446458fc70823884d51
Submitter: Guy Harris (guy@xxxxxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

77bc38e by Guy Harris (guy@xxxxxxxxxxxx):

    Clean up handling of buffer size.
    
    Instead of a twisty little maze of #if, #ifdefs, and #elifs, all
    different, define HAVE_BUFFER_SIZE upfront iff we can set the buffer
    size - i.e., if this is Win32, and thus we're using WinPcap, or if we
    have pcap_create() and thus pcap_set_buffer_size() - and use that to
    govern whether to have a buffer size setting or not.
    
    Always put the buffer size setting in the right vertical box.  If that
    doesn't work well for some configurations of available interface knobs,
    feel free to change the checks, but please make it less opaque what's
    going on (include a comment if necessary).
    
    Change-Id: I384c601982b470ae08de271431eac06d6c925332
    Reviewed-on: https://code.wireshark.org/review/7814
    Reviewed-by: Guy Harris <guy@xxxxxxxxxxxx>
    

Actions performed:

    from  162f266   Generate format strings at compile time.
    adds  77bc38e   Clean up handling of buffer size.


Summary of changes:
 ui/gtk/capture_dlg.c |   80 +++++++++++++++++++++++++-------------------------
 1 file changed, 40 insertions(+), 40 deletions(-)