Wireshark-commits: [Wireshark-commits] master ae20651: Overhaul WSP dissector.
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Tue, 24 Mar 2015 05:01:34 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=ae20651d9a517ee3d37fa8b840b1c2b7bf5ceeac
Submitter: Anders Broman (a.broman58@xxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

ae20651 by Michael Mann (mmann78@xxxxxxxxxxxx):

    Overhaul WSP dissector.
    
    1. Remove proto_tree_add_text (the reason I started the update)
    2. Add expert info (mostly related to proto_tree_add_text, but since I was in the neighborhood...)
    3. Replace "big functions macros" with "small macro" + real function (for big .o size savings)
    4. Remove DebugLog macro (intent seems to duplicate basic functionality of a step-through debugger)
    5. Replace HF_EMPTY (and comparible macros) with -1
    6. Move header handler array to remove need for many forward declarations.
    
    Change-Id: Ic5467289aae7d54e78c1fd65f93358387d6139aa
    Reviewed-on: https://code.wireshark.org/review/7799
    Petri-Dish: Michael Mann <mmann78@xxxxxxxxxxxx>
    Tested-by: Petri Dish Buildbot <buildbot-no-reply@xxxxxxxxxxxxx>
    Reviewed-by: Anders Broman <a.broman58@xxxxxxxxx>
    

Actions performed:

    from  a6fc6aa   wcp: add validations to decompressed_entry
    adds  ae20651   Overhaul WSP dissector.


Summary of changes:
 epan/dissectors/packet-mmse.c |    2 +-
 epan/dissectors/packet-wsp.c  | 4020 ++++++++++++++++++++---------------------
 epan/dissectors/packet-wsp.h  |    2 +-
 3 files changed, 1963 insertions(+), 2061 deletions(-)