Wireshark-commits: [Wireshark-commits] master 1b41208: Centralize the code to set the active_dlt va
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Mon, 23 Mar 2015 00:00:46 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=1b4120846ee1a139f7d3ff9c2bfe2eab593745bb
Submitter: Guy Harris (guy@xxxxxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

1b41208 by Guy Harris (guy@xxxxxxxxxxxx):

    Centralize the code to set the active_dlt value for a device.
    
    We were doing it similarly, but not the same, in several places; make a
    common routine for it.
    
    Have that code check to make sure the DLT_ value in question is actually
    supported by the device; if not, pick the first supported DLT_ value, if
    any; this keeps it from, for example, picking a bad DLT_ value if your
    defaults were set based on monitor mode being on but monitor mode
    actually being off, or vice versa.
    
    Change-Id: I1722bfeaf60429bc5c6f665fdea3d466052b13bd
    Reviewed-on: https://code.wireshark.org/review/7795
    Reviewed-by: Guy Harris <guy@xxxxxxxxxxxx>
    

Actions performed:

    from  c474bb8   Update libwireshark0.symbols file
    adds  1b41208   Centralize the code to set the active_dlt value for a device.


Summary of changes:
 ui/capture_ui_utils.c               |   51 +++++++++++++++++++++++++++++++++++
 ui/capture_ui_utils.h               |    7 +++++
 ui/gtk/capture_dlg.c                |    4 +--
 ui/iface_lists.c                    |   23 ++++------------
 ui/qt/capture_interfaces_dialog.cpp |    5 ++--
 5 files changed, 66 insertions(+), 24 deletions(-)