Wireshark-commits: [Wireshark-commits] master 6c38340: MQTT: Prevent subsequent messages from overw
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Fri, 20 Mar 2015 23:46:36 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=6c383407895c09abd3988c1ae90de758b462072f
Submitter: Michael Mann (mmann78@xxxxxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

6c38340 by Alexander Stein (alexanders83@xxxxxx):

    MQTT: Prevent subsequent messages from overwriting the Info column
    
    Without a fence col_add_fstr will overwrite the whole column on each
    message.
    Instead of adding a fence and adding the message info use
    col_append_sep_str which also supports a separator out of the box.
    e.g. "Connect Command, Publish Message, Disconnect Req"
    
    Change-Id: I346d9b659a044143cd31f08081ad145b9186307c
    Signed-off-by: Alexander Stein <alexanders83@xxxxxx>
    Reviewed-on: https://code.wireshark.org/review/7771
    Petri-Dish: Michael Mann <mmann78@xxxxxxxxxxxx>
    Tested-by: Petri Dish Buildbot <buildbot-no-reply@xxxxxxxxxxxxx>
    Reviewed-by: Michael Mann <mmann78@xxxxxxxxxxxx>
    

Actions performed:

    from  2afb524   MQTT: Dissect on default port automatically
    adds  6c38340   MQTT: Prevent subsequent messages from overwriting the Info column


Summary of changes:
 epan/dissectors/packet-mqtt.c |    4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)