Wireshark-commits: [Wireshark-commits] master cb31cc6: Fix extracting of parameter.
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Thu, 19 Mar 2015 00:48:26 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=cb31cc61d7717848a47f65809f0e97a905ae9240
Submitter: Guy Harris (guy@xxxxxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

cb31cc6 by Guy Harris (guy@xxxxxxxxxxxx):

    Fix extracting of parameter.
    
    We have to find the closing parenthesis before overwriting the opening
    parenthesis, otherwise the end of the string, from which strrchr()
    searches, is at the point where the opening parenthesis was.
    
    Fix incorrect arithmetic (-1 + -1 + 1 = -1, not 1).
    
    Change-Id: Ida47dd9670b36269eef28368aa845301a7185c3f
    Reviewed-on: https://code.wireshark.org/review/7747
    Reviewed-by: Guy Harris <guy@xxxxxxxxxxxx>
    

Actions performed:

    from  c691af8   Fix a comment.
    adds  cb31cc6   Fix extracting of parameter.


Summary of changes:
 ui/capture_ui_utils.c |   18 +++++++++---------
 1 file changed, 9 insertions(+), 9 deletions(-)