Wireshark-commits: [Wireshark-commits] master e6f3da9: Qt: Fix recent files threads
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Wed, 18 Mar 2015 08:52:01 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=e6f3da96f8976c2808bd9973b420a76ecfca08f4
Submitter: Anders Broman (a.broman58@xxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

e6f3da9 by Michal Labedzki (michal.labedzki@xxxxxxxxx):

    Qt: Fix recent files threads
    
    Fix crash and memory leak. Please not that
    Recent File Status objects and threads still
    continously grow and shrink memory usage, but do not
    grow continuously.
    
    Bug: 10893
    Change-Id: Icc8b7fefd6572b902ac81d22e5f7b16e304fcf16
    Reviewed-on: https://code.wireshark.org/review/7699
    Petri-Dish: Michal Labedzki <michal.labedzki@xxxxxxxxx>
    Reviewed-by: Gerald Combs <gerald@xxxxxxxxxxxxx>
    Tested-by: Petri Dish Buildbot <buildbot-no-reply@xxxxxxxxxxxxx>
    Reviewed-by: Anders Broman <a.broman58@xxxxxxxxx>
    

Actions performed:

    from  dfc0689   [BOOTP] Try to fix the build boot by casting a variable to 32bits while at it replace tvb_length() with tvb_reported_length().
    adds  e6f3da9   Qt: Fix recent files threads


Summary of changes:
 ui/qt/recent_file_status.cpp    |   24 +++++++++++-------------
 ui/qt/recent_file_status.h      |   25 ++++++++++++-------------
 ui/qt/wireshark_application.cpp |   15 +--------------
 3 files changed, 24 insertions(+), 40 deletions(-)