Wireshark-commits: [Wireshark-commits] lts-1.8.2 beca96a: Pcapng: Don't fetch past the end of a GAr
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Tue, 17 Mar 2015 15:55:21 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=beca96a9ca90ad1e79f780937c9f0652666a5be4
Submitter: Balint Reczey (balint@xxxxxxxxxxxxxxx)
Changed: branch: lts-1.8.2
Repository: wireshark

Commits:

beca96a by Gerald Combs (gerald@xxxxxxxxxxxxx):

    Pcapng: Don't fetch past the end of a GArray.
    
    Due to an off-by-one error an invalid ISB interface ID could make us
    fetch past the end of a GArray. Found using American Fuzzy Lop.
    
    Bug: 10895
    Change-Id: I7d4049ad7a386ae7e8013b8e741d54a31f353f1f
    Reviewed-on: https://code.wireshark.org/review/6798
    Petri-Dish: Gerald Combs <gerald@xxxxxxxxxxxxx>
    Tested-by: Petri Dish Buildbot <buildbot-no-reply@xxxxxxxxxxxxx>
    Reviewed-by: Gerald Combs <gerald@xxxxxxxxxxxxx>
    (cherry picked from commit a835c85e3d662343d7283f1dcdacb8a11d1d0727)
    Conflicts: wiretap/pcapng.c
    Reviewed-on: https://code.wireshark.org/review/6801
    Conflicts: wiretap/pcapng.c
    Reviewed-on: https://code.wireshark.org/review/7713
    Reviewed-by: Balint Reczey <balint@xxxxxxxxxxxxxxx>
    Tested-by: Balint Reczey <balint@xxxxxxxxxxxxxxx>
    

Actions performed:

    from  e3f1da4   tnef: fix overflow leading to infinite loop
    adds  beca96a   Pcapng: Don't fetch past the end of a GArray.


Summary of changes:
 wiretap/pcapng.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)