Wireshark-commits: [Wireshark-commits] lts-1.12.1 bf4ed6e: Pcapng: Don't fetch past the end of a GA
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Tue, 17 Mar 2015 14:25:05 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=bf4ed6e1ed9f3b29c9a7208e37a332aebe6b5ca5
Submitter: Balint Reczey (balint@xxxxxxxxxxxxxxx)
Changed: branch: lts-1.12.1
Repository: wireshark

Commits:

bf4ed6e by Gerald Combs (gerald@xxxxxxxxxxxxx):

    Pcapng: Don't fetch past the end of a GArray.
    
    Due to an off-by-one error an invalid ISB interface ID could make us
    fetch past the end of a GArray. Found using American Fuzzy Lop.
    
    Bug: 10895
    Change-Id: I7d4049ad7a386ae7e8013b8e741d54a31f353f1f
    Reviewed-on: https://code.wireshark.org/review/6798
    Petri-Dish: Gerald Combs <gerald@xxxxxxxxxxxxx>
    Tested-by: Petri Dish Buildbot <buildbot-no-reply@xxxxxxxxxxxxx>
    Reviewed-by: Gerald Combs <gerald@xxxxxxxxxxxxx>
    (cherry picked from commit a835c85e3d662343d7283f1dcdacb8a11d1d0727)
    Conflicts: wiretap/pcapng.c
    Reviewed-on: https://code.wireshark.org/review/6801
    Reviewed-on: https://code.wireshark.org/review/7704
    Reviewed-by: Balint Reczey <balint@xxxxxxxxxxxxxxx>
    Tested-by: Balint Reczey <balint@xxxxxxxxxxxxxxx>
    

Actions performed:

    from  13bdc0f   ATN-CPDLC: never put a break in a TRY block
    adds  bf4ed6e   Pcapng: Don't fetch past the end of a GArray.


Summary of changes:
 wiretap/pcapng.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)