Wireshark-commits: [Wireshark-commits] master a9c75ca: Avoid abort on zero-length fields
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Thu, 12 Mar 2015 00:59:36 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=a9c75ca3c8251d465d6350f1783ab3c972979a2f
Submitter: Michael Mann (mmann78@xxxxxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

a9c75ca by Peter Wu (peter@xxxxxxxxxxxxx):

    Avoid abort on zero-length fields
    
    Since commit v1.99.4rc0-70-g0bec885 (Remove use of sprintf for ftype
    string formatting), Wireshark aborts with "Null pointer passed to
    bytes_to_hexstr_punct()". This happened with a SSL capture where the
    ssl.handshake.extensions_padding_data had a zero length.
    
    Fix it by producing a zero-length string instead (as done by the
    previous implementation).
    
    Change-Id: I711d786a9ae692eb44c5e49a30d5fea41c5af31e
    Reviewed-on: https://code.wireshark.org/review/7649
    Reviewed-by: Michael Mann <mmann78@xxxxxxxxxxxx>
    

Actions performed:

    from  0bec885   Remove use of sprintf for ftype string formatting
    adds  a9c75ca   Avoid abort on zero-length fields


Summary of changes:
 epan/ftypes/ftype-bytes.c  |    3 ++-
 epan/ftypes/ftype-tvbuff.c |    3 ++-
 2 files changed, 4 insertions(+), 2 deletions(-)