Wireshark-commits: [Wireshark-commits] master-1.12 c8f15ac: packet-spnego: fix krb5_cfx_wrap withou
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Wed, 11 Mar 2015 16:28:01 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=c8f15ac69b7e81ea52fa7b2daeb1337e372058f8
Submitter: Evan Huus (eapache@xxxxxxxxx)
Changed: branch: master-1.12
Repository: wireshark

Commits:

c8f15ac by Stefan Metzmacher (metze@xxxxxxxxx):

    packet-spnego: fix krb5_cfx_wrap without encryption
    
    We need to use rrc, as the checksum is likely to be
    rotated before the plaintext payload.
    
    For now we only handle the two common cases
    rrc == 0 and rrc == ec...
    
    Ping-Bug: 9398
    Conflicts:
    	asn1/spnego/packet-spnego-template.c
    	epan/dissectors/packet-spnego.c
    
    Change-Id: I548f2f0650716294b6aeb361021be6e44ae8f1b3
    Signed-off-by: Stefan Metzmacher <metze@xxxxxxxxx>
    Reviewed-on: https://code.wireshark.org/review/7271
    Reviewed-by: Michael Mann <mmann78@xxxxxxxxxxxx>
    Reviewed-on: https://code.wireshark.org/review/7624
    Reviewed-by: Evan Huus <eapache@xxxxxxxxx>
    

Actions performed:

    from  ade8eab   rpc: Prevent "malformed" for RPC 'NULL proc' packets.
    adds  c8f15ac   packet-spnego: fix krb5_cfx_wrap without encryption


Summary of changes:
 asn1/spnego/packet-spnego-template.c |   31 +++++++++++++++++++++++-------
 epan/dissectors/packet-spnego.c      |   35 +++++++++++++++++++++++++---------
 2 files changed, 50 insertions(+), 16 deletions(-)