Wireshark-commits: [Wireshark-commits] master-1.12 a0666d8: forces: make redirecttlv robust to inva
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Tue, 10 Mar 2015 15:54:11 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=a0666d8f5d41f738b0b037f7451319f630f4fe92
Submitter: Evan Huus (eapache@xxxxxxxxx)
Changed: branch: master-1.12
Repository: wireshark

Commits:

a0666d8 by Evan Huus (eapache@xxxxxxxxx):

    forces: make redirecttlv robust to invalid lengths
    
    Fixes a potential infinite loop reported by Vlad Tsyrklevich found via the
    "joern" tool. I'm pretty sure the semantics of proto_tree_add_item would have
    prevented this, but not 100% and making it explicit doesn't hurt.
    
    Bug: 11037
    Change-Id: I92049a95d23ca9c233b3fd830637e6bca19a7434
    Reviewed-on: https://code.wireshark.org/review/7592
    Petri-Dish: Evan Huus <eapache@xxxxxxxxx>
    Tested-by: Petri Dish Buildbot <buildbot-no-reply@xxxxxxxxxxxxx>
    Reviewed-by: Evan Huus <eapache@xxxxxxxxx>
    (cherry picked from commit 8ff55a910ee0408910cbbe6d1823987f47f8f521)
    Reviewed-on: https://code.wireshark.org/review/7617
    

Actions performed:

    from  5cffcdb   fix fields format when printing
    adds  a0666d8   forces: make redirecttlv robust to invalid lengths


Summary of changes:
 epan/dissectors/packet-forces.c |   11 ++++++++---
 1 file changed, 8 insertions(+), 3 deletions(-)