Wireshark-commits: [Wireshark-commits] master 758ee3d: Qt: fix use of uninitialized variable
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Sun, 8 Mar 2015 21:54:56 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=758ee3dc899ecd7b0de9179fc4d4d7a88e05d27e
Submitter: Peter Wu (peter@xxxxxxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

758ee3d by Peter Wu (peter@xxxxxxxxxxxxx):

    Qt: fix use of uninitialized variable
    
    Fixes error reported by UBSan:
    
        ui/qt/packet_list.cpp:537:13: runtime error: load of value 190, which is not a valid value for type 'bool'
    
    The method is apparently called earlier for other timers, resulting in
    an error on startup. Initialize rows_inserted_ to avoid warnings when
    the event is triggered later.
    
    Change-Id: Iad919d79264ff1c3c17c9458c869d584234fcd5d
    Reviewed-on: https://code.wireshark.org/review/7575
    Reviewed-by: Peter Wu <peter@xxxxxxxxxxxxx>
    

Actions performed:

    from  27ff75c   ULP/ILP: add dissection of MSISDN, MDN and IMSI numbers
    adds  758ee3d   Qt: fix use of uninitialized variable


Summary of changes:
 ui/qt/packet_list.cpp |    3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)