Wireshark-commits: [Wireshark-commits] master 9c2b593: alljoyn: more robust signature handling
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Fri, 6 Mar 2015 12:15:32 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=9c2b593dc873c8971f9794b979f1a24a24edc545
Submitter: Michael Mann (mmann78@xxxxxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

9c2b593 by Evan Huus (eapache@xxxxxxxxx):

    alljoyn: more robust signature handling
    
    There were two bugs in the handling of all-joyn struct signatures:
     - we were advancing the pointer without decrementing the length remaining
     - we were not checking for the string's null-terminator (which is only
       necessary if the string is malformed, but that's entirely possible)
    
    Bug: 11028
    Change-Id: I38b98cf3f43681f709846e3cb9068d20c4fdce82
    Reviewed-on: https://code.wireshark.org/review/7552
    Reviewed-by: Evan Huus <eapache@xxxxxxxxx>
    Petri-Dish: Evan Huus <eapache@xxxxxxxxx>
    Tested-by: Petri Dish Buildbot <buildbot-no-reply@xxxxxxxxxxxxx>
    Reviewed-by: Michael Mann <mmann78@xxxxxxxxxxxx>
    

Actions performed:

    from  ebc47e4   slarp: added reliability field + expert info
    adds  9c2b593   alljoyn: more robust signature handling


Summary of changes:
 epan/dissectors/packet-alljoyn.c |    4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)