Wireshark-commits: [Wireshark-commits] master 99ceab8: Don't create a packet dialog if we don't hav
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Mon, 2 Mar 2015 04:01:47 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=99ceab898c8c809eb1584432c54872d7e368711b
Submitter: Guy Harris (guy@xxxxxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

99ceab8 by Guy Harris (guy@xxxxxxxxxxxx):

    Don't create a packet dialog if we don't have a packet.
    
    Move the "find the frame" stuff to openPacketDialog(), and don't even
    bother creating a new PacketDialog if we don't find the frame.  This
    should squelch Coverity CID 1270934, by giving up quickly if fdata is
    null.
    
    Change-Id: I4605ba7e271a55724f02cafed4122f9dd9b1b6f7
    Reviewed-on: https://code.wireshark.org/review/7467
    Reviewed-by: Guy Harris <guy@xxxxxxxxxxxx>
    

Actions performed:

    from  3108bf8   Fix typo caught by Coverity - wrong structure members being tested.
    adds  99ceab8   Don't create a packet dialog if we don't have a packet.


Summary of changes:
 ui/qt/main_window_slots.cpp |   27 ++++++++++++++++++++++-----
 ui/qt/packet_dialog.cpp     |   12 +-----------
 ui/qt/packet_dialog.h       |    2 +-
 3 files changed, 24 insertions(+), 17 deletions(-)