Wireshark-commits: [Wireshark-commits] master 946856a: Move tests out of try_dissect_linux_usb_pseu
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Wed, 28 Jan 2015 09:17:42 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=946856ada23bf399458265e25b1f68dbd455e756
Submitter: Guy Harris (guy@xxxxxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

946856a by Guy Harris (guy@xxxxxxxxxxxx):

    Move tests out of try_dissect_linux_usb_pseudo_header_ext().
    
    Do the tests in its callers; rename it to just
    dissect_linux_usb_pseudo_header_ext() and don't bother passing it the
    header_info flag.
    
    We can remove some of those tests as they're already done in the caller.
    
    Change-Id: I7c3cfefba833a84c834462307088f5c31612128e
    Reviewed-on: https://code.wireshark.org/review/6829
    Reviewed-by: Guy Harris <guy@xxxxxxxxxxxx>
    

Actions performed:

    from  f090ebb   Add documentation URLs for the Linux USB and USBPCAP pseudo-headers.
    adds  946856a   Move tests out of try_dissect_linux_usb_pseudo_header_ext().


Summary of changes:
 epan/dissectors/packet-usb.c |   54 +++++++++++++++++++++++-------------------
 1 file changed, 30 insertions(+), 24 deletions(-)