Wireshark-commits: [Wireshark-commits] master 4fb2ec0: SMC-R: fix incorrect dissection of non-SMCR
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Tue, 27 Jan 2015 05:45:31 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=4fb2ec0053115ec5b409d7cfc537a63813135acd
Submitter: Anders Broman (a.broman58@xxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

4fb2ec0 by Joe Fowler (fowlerja@xxxxxxxxxx):

    SMC-R: fix incorrect dissection of non-SMCR packet. Failover
    Validation bit definition is missing
    
    dissect_smcr_tcp_heur() passes incorrect length to tvb_memeql(),
    resulting in incorrectly identifying a packet as SMC-R.
    
    Added Failover Validation bit.
    
    Bug: 10887
    Change-Id: I9f33389bd974b4c410a6b077d0d133221c77ee0d
    Reviewed-on: https://code.wireshark.org/review/6765
    Reviewed-by: Anders Broman <a.broman58@xxxxxxxxx>
    

Actions performed:

    from  ee320ef   qt: clear tree and bytes when no packet selected
    adds  4fb2ec0   SMC-R: fix incorrect dissection of non-SMCR packet. Failover Validation bit definition is missing


Summary of changes:
 epan/dissectors/packet-smcr.c |   12 ++++++++++--
 1 file changed, 10 insertions(+), 2 deletions(-)