Wireshark-commits: [Wireshark-commits] master aec1bcf: Lua can free tvbuffs too early
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Sun, 25 Jan 2015 19:11:05 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=aec1bcf9a14116763f6fd4438173c5a953df7d18
Submitter: Hadriel Kaplan (hadrielk@xxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

aec1bcf by Hadriel Kaplan (hadrielk@xxxxxxxxx):

    Lua can free tvbuffs too early
    
    Lua-created tvbuffs should be kept around for the duration of pinfo's
    lifetime, instead of only for the duration of frame dissection. So
    instead of using the frame dissector's frame_end_routine, we'll register
    a callback to wmem for pinfo pool's allocator.
    
    Bug: 10888
    Change-Id: I3e9db671c3f2a7cab9e258aca17f3be8acaf2417
    Reviewed-on: https://code.wireshark.org/review/6768
    Petri-Dish: Hadriel Kaplan <hadrielk@xxxxxxxxx>
    Tested-by: Petri Dish Buildbot <buildbot-no-reply@xxxxxxxxxxxxx>
    Reviewed-by: Evan Huus <eapache@xxxxxxxxx>
    Reviewed-by: Hadriel Kaplan <hadrielk@xxxxxxxxx>
    Tested-by: Hadriel Kaplan <hadrielk@xxxxxxxxx>
    

Actions performed:

    from  716f9a3   [Automatic manuf, services and enterprise-numbers update for 2015-01-25]
    adds  aec1bcf   Lua can free tvbuffs too early


Summary of changes:
 doc/README.wmem          |    2 +-
 epan/wmem/wmem_user_cb.h |    2 +-
 epan/wslua/init_wslua.c  |   11 ++++++++---
 3 files changed, 10 insertions(+), 5 deletions(-)