Wireshark-commits: [Wireshark-commits] master b2a5f15: RTPS: Memset entire buffer
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Sat, 24 Jan 2015 19:31:24 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=b2a5f15fbe44bdf46dd2c7ce4c49ab60f1d53409
Submitter: Evan Huus (eapache@xxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

b2a5f15 by Evan Huus (eapache@xxxxxxxxx):

    RTPS: Memset entire buffer
    
    Apparently some compilers do sufficient inlining optimization to notice that
    there's at least one caller of rtps_util_add_typecode which passes an
    indent_level of 0. Such compilers are *also* picky enough to complain about
    memset being called with a length of 0, leading to a warning which we turn into
    a compile error.
    
    I thought about putting in an "if indent_level > 0" but I figure memsetting the
    entire buffer (length >= 1) is simpler and more efficient in the common case.
    
    Change-Id: Ica21ba988eb0c1251e7b4ef2e110336d5ee32837
    Reviewed-on: https://code.wireshark.org/review/6766
    Reviewed-by: Evan Huus <eapache@xxxxxxxxx>
    

Actions performed:

    from  cf142c6   Get Wireshark to compile with afl-gcc.
    adds  b2a5f15   RTPS: Memset entire buffer


Summary of changes:
 epan/dissectors/packet-rtps.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)