Wireshark-commits: [Wireshark-commits] master-1.12 b747dfc: Remove incorrect 'if (tree)'
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Fri, 23 Jan 2015 17:59:09 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=b747dfcb3bd7ea1496b041c26208e3ef385e0f77
Submitter: Bill Meier (wmeier@xxxxxxxxxxx)
Changed: branch: master-1.12
Repository: wireshark

Commits:

b747dfc by Bill Meier (wmeier@xxxxxxxxxxx):

    Remove incorrect 'if (tree)'
    
    Incorrect because of one or both of the following:
    - col_...()/expert...() called under 'if (tree)'
    - vars set under 'if (tree)' used later (not under 'if (tree)'
       as args to col_...()/expert_...()
    
    Change-Id: I090cbbf00277d831898ff58a83a7a17ad2b04aee
    Reviewed-on: https://code.wireshark.org/review/6761
    Reviewed-by: Bill Meier <wmeier@xxxxxxxxxxx>
    

Actions performed:

    from  4acb150   Get rid of an unused variable.
    adds  b747dfc   Remove incorrect 'if (tree)'


Summary of changes:
 epan/dissectors/packet-extreme.c     |  226 +++++++++++++++++-----------------
 epan/dissectors/packet-ismacryp.c    |    4 +-
 epan/dissectors/packet-kdp.c         |    2 +-
 epan/dissectors/packet-mgcp.c        |    2 +-
 epan/dissectors/packet-netflow.c     |   14 +--
 epan/dissectors/packet-tivoconnect.c |    2 +-
 epan/dissectors/packet-v52.c         |    3 +-
 7 files changed, 123 insertions(+), 130 deletions(-)