Wireshark-commits: [Wireshark-commits] master 888229b: Make netlink dissector register the attribut
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Fri, 23 Jan 2015 05:33:49 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=888229bebd2cbb070cc89168510a880b50daf6c4
Submitter: Anders Broman (a.broman58@xxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

888229b by Hadriel Kaplan (hadrielk@xxxxxxxxx):

    Make netlink dissector register the attribute length header field info
    
    The header field info variable named hfi_netlink_len isn't registered
    by the netlink dissector, but is added to the tree, resulting in a
    runtime error. This commit changes the variable name slightly, to
    be more accurate, and correctly registers it.
    
    Bug: 10884
    Change-Id: Iaa4e556d5bbe87b72a0cdca2fbf397fa95e074cc
    Reviewed-on: https://code.wireshark.org/review/6751
    Reviewed-by: Hadriel Kaplan <hadrielk@xxxxxxxxx>
    Petri-Dish: Hadriel Kaplan <hadrielk@xxxxxxxxx>
    Tested-by: Petri Dish Buildbot <buildbot-no-reply@xxxxxxxxxxxxx>
    Reviewed-by: Anders Broman <a.broman58@xxxxxxxxx>
    

Actions performed:

    from  407b703   Fix some WsLua documentation errors
    adds  888229b   Make netlink dissector register the attribute length header field info


Summary of changes:
 epan/dissectors/packet-netlink.c |    9 ++++++---
 1 file changed, 6 insertions(+), 3 deletions(-)