Wireshark-commits: [Wireshark-commits] master d93a90b: Make the individual install_ and uninstall_
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Thu, 22 Jan 2015 02:10:15 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=d93a90b445d1e5821eec32e1e2327d5836188fff
Submitter: Guy Harris (guy@xxxxxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

d93a90b by Guy Harris (guy@xxxxxxxxxxxx):

    Make the individual install_ and uninstall_ functions idempotent.
    
    Move the "do I want this and, if so, is it already installed?" checks
    into the install_ functions.
    
    Move the "is this already installed?" checks into the uninstall_
    functions, and have them clear the appropriate installed version
    variable when finished.
    
    Also, fetch the installed versions early in the main line.
    
    Change-Id: I9e5d8ca48285c6d424a4a2a5f53f4aa449a891d3
    Reviewed-on: https://code.wireshark.org/review/6730
    Reviewed-by: Guy Harris <guy@xxxxxxxxxxxx>
    

Actions performed:

    from  33c1858   Pull the installs into a function.
    adds  d93a90b   Make the individual install_ and uninstall_ functions idempotent.


Summary of changes:
 macosx-setup.sh | 1655 ++++++++++++++++++++++++++++---------------------------
 1 file changed, 844 insertions(+), 811 deletions(-)