Wireshark-commits: [Wireshark-commits] master 32ab59f: synphasor: General cleanup
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=32ab59f8e90317ed644fff37379fd4a76e1a9dae
Submitter: Bill Meier (wmeier@xxxxxxxxxxx)
Changed: branch: master
Repository: wireshark
Commits:
32ab59f by Bill Meier (wmeier@xxxxxxxxxxx):
synphasor: General cleanup
- col_...() shouldn't be under 'if (tree)';
- remove dead initializers;
- use proto_tree_add_subtree() in place of ..._add_text()/...add_subtree()
in one more instance;
- tvb_length() --> tvb_reported_length();
- use 'proto tree *' variable instead of incorrect 'proto_item *' var in
one instance;
- use SYNP_... for a few macro names to prevent any possible
namespace collisions;
- fix some long-lines, indentation and whitespace.
Change-Id: I4e0a2e5d0b5e13b72a14ec6dd3779a7104534445
Reviewed-on: https://code.wireshark.org/review/6720
Reviewed-by: Bill Meier <wmeier@xxxxxxxxxxx>
Actions performed:
from 009ca9f srvloc: fix a very minor bug
adds 32ab59f synphasor: General cleanup
Summary of changes:
epan/dissectors/packet-synphasor.c | 193 +++++++++++++++++++-----------------
1 file changed, 101 insertions(+), 92 deletions(-)