Wireshark-commits: [Wireshark-commits] master bf23953: Only turn -msse4.2 on for ws_mempbrk_sse42.c
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Wed, 21 Jan 2015 02:45:39 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=bf239535b9c054d7d8d919558ff352c8ce648842
Submitter: Guy Harris (guy@xxxxxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

bf23953 by Guy Harris (guy@xxxxxxxxxxxx):

    Only turn -msse4.2 on for ws_mempbrk_sse42.c, and don't always build it.
    
    Move all the SSE 4.2 stuff to wsutil/CMakeLists.txt.
    
    Don't put ws_mempbrk_sse42.c in WSUTIL_FILES by default; add it if we
    think the compiler supports compiling for SSE 4.2.
    
    Add -msse4.2 to its COMPILE_FLAGS, but don't add it to any other
    compiler flags - we don't want to build anything else with -msse4.2 by
    default, as the only code that uses SSE 4.2 instructions but *only* does
    so if the processor supports it is our mempbrk implementation.  (And
    *add* it, don't *replace* the existing flags with -msse4.2; that way,
    -Werror is left in there as well.)
    
    Change-Id: I979b37a37e4b88b3af11e2275e89441118c8ce0a
    Reviewed-on: https://code.wireshark.org/review/6698
    Reviewed-by: Guy Harris <guy@xxxxxxxxxxxx>
    

Actions performed:

    from  f215102   Handle CFLAGS disabling SSE 4.2.
    adds  bf23953   Only turn -msse4.2 on for ws_mempbrk_sse42.c, and don't always build it.


Summary of changes:
 CMakeLists.txt        |   20 --------------------
 wsutil/CMakeLists.txt |   26 +++++++++++++++++++++++---
 2 files changed, 23 insertions(+), 23 deletions(-)