Wireshark-commits: [Wireshark-commits] master-1.12 597e00b: The times in question are local, not UT
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Tue, 20 Jan 2015 03:01:02 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=597e00b71e0c31acbd4a5cfb45a4a533dfc4e06e
Submitter: Bill Meier (wmeier@xxxxxxxxxxx)
Changed: branch: master-1.12
Repository: wireshark

Commits:

597e00b by Guy Harris (guy@xxxxxxxxxxxx):

    The times in question are local, not UTC.
    
    Revert to the older code, but just show the time as "Not representable"
    if gmtime() fails.
    
    Change-Id: I435facc042e3ca35fb07292a4b2657ccdfd02abb
    Reviewed-on: https://code.wireshark.org/review/6672
    Reviewed-by: Guy Harris <guy@xxxxxxxxxxxx>
    (cherry picked from commit bea25fa0d43d11ddf4f38c6b15e69a038d0e8467)
    Reviewed-on: https://code.wireshark.org/review/6679
    Reviewed-by: Bill Meier <wmeier@xxxxxxxxxxx>
    

Actions performed:

    from  4946e93   synphasor: prevent possible crash; gmtime() can return NULL;
    adds  597e00b   The times in question are local, not UTC.


Summary of changes:
 epan/dissectors/packet-smb-pipe.c |   34 ++++++++++++++++++++++++++--------
 1 file changed, 26 insertions(+), 8 deletions(-)