Wireshark-commits: [Wireshark-commits] master f90a10a: epl: Rework POWERLINK (EPL) dissector
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Mon, 19 Jan 2015 07:18:52 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=f90a10a0d57b4e7fd56ca4312be733cb27598dbc
Submitter: Anders Broman (a.broman58@xxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

f90a10a by Josef Baumgartner (josef.baumgartner@xxxxxxxxxxxxxxxxx):

    epl: Rework POWERLINK (EPL) dissector
    
     With this patch we want to enable a better support of POWERLINK
     as a protocol for people who have to perform network diagnostics using
     analyzing tools. Up until now, the main tool used was Omnipeek.
     Now wireshark will be used more and more, due to the new extcap
     infrastructure, which supports debug tools to be added as capture
     devices.
    
     To better facilitate that change, we have adapted the textual
     representation of the Omnipeek dissector for POWERLINK, as it
     allows for a faster and simpler diagnosis routine.
    
     Additionally the name of the protocol has been changed to it's
     correct name "POWERLINK" as this is the official name used by
     EPSG for describing the protocol.
    
    Changelog:
     - Add error code definitions and string values.
     - Change name for protocol column to POWERLINK which is more commonly
       used than EPL.
     - Reformat output in info column to look like output the output of
       the POWERLINK plugin for Omnipeek. This facilitates the transition
       to Wireshark. The added information and changed output improves the
       debugging of POWERLINK nerworks.
    
    Change-Id: I795e2487f2ae7af6b90c29366a1843c9fabffa85
    Reviewed-on: https://code.wireshark.org/review/5581
    Reviewed-by: Roland Knall <rknall@xxxxxxxxx>
    Petri-Dish: Anders Broman <a.broman58@xxxxxxxxx>
    Reviewed-by: Anders Broman <a.broman58@xxxxxxxxx>
    

Actions performed:

    from  f53be88   JSON dissector changed into heuristic dissector.
    adds  f90a10a   epl: Rework POWERLINK (EPL) dissector


Summary of changes:
 epan/dissectors/packet-epl.c |  592 ++++++++++++++++++++++++++++--------------
 1 file changed, 401 insertions(+), 191 deletions(-)