Wireshark-commits: [Wireshark-commits] master ef0435b: ZigBee: don't use packet_scope outside of di
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Thu, 15 Jan 2015 13:34:23 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=ef0435bdb567e8e4cde7032617bb83aafc8bb162
Submitter: Evan Huus (eapache@xxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

ef0435b by Evan Huus (eapache@xxxxxxxxx):

    ZigBee: don't use packet_scope outside of dissection
    
    The decode_* functions defined here are called post-dissection for formatting
    labels, so don't have access to packet scope. Just use and free manual memory.
    
    Introduced in gbdfabe59.
    
    Bug: 10855
    Change-Id: I9b0085b1f7779ae6fbd12482c44d8f611cdbb49f
    Reviewed-on: https://code.wireshark.org/review/6545
    Reviewed-by: Evan Huus <eapache@xxxxxxxxx>
    

Actions performed:

    from  c2350a5   rsvp: fix typo
    adds  ef0435b   ZigBee: don't use packet_scope outside of dissection


Summary of changes:
 epan/dissectors/packet-zbee-zcl-general.c |   40 +++++++++++++++++++----------
 1 file changed, 26 insertions(+), 14 deletions(-)