Wireshark-commits: [Wireshark-commits] master f90eeb1: When allocating address structures, use wmem
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Tue, 13 Jan 2015 04:36:28 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=f90eeb1775b2201fa14d8c8378603325daa89cd2
Submitter: Guy Harris (guy@xxxxxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

f90eeb1 by Guy Harris (guy@xxxxxxxxxxxx):

    When allocating address structures, use wmem_new0().
    
    For structures used as the data in an address, use wmem_new(), so that
    structure padding is zeroed out; the comparison code for addresses
    compares all bytes of the structure for addresses that are structures,
    and the hashing code for hash tables using addresses as keys hash all
    the bytes, so we have to make sure that, for addresses that are the
    same, *all* bytes are the same.
    
    Change-Id: I995fd26cc2f20edb5a599f95562b720561708e57
    Reviewed-on: https://code.wireshark.org/review/6517
    Reviewed-by: Guy Harris <guy@xxxxxxxxxxxx>
    

Actions performed:

    from  b204ff4   Do bounds checking when decompressing WCP packets.
    adds  f90eeb1   When allocating address structures, use wmem_new0().


Summary of changes:
 epan/dissectors/packet-atalk.c |    8 ++++----
 epan/dissectors/packet-sna.c   |    4 ++--
 epan/dissectors/packet-usb.c   |    4 ++--
 3 files changed, 8 insertions(+), 8 deletions(-)