Wireshark-commits: [Wireshark-commits] master-1.12 c59e0a8: Do bounds checking when decompressing W
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Tue, 13 Jan 2015 04:08:51 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=c59e0a85e2a378e87a9c0bfb2fd58bd88f1ac890
Submitter: Guy Harris (guy@xxxxxxxxxxxx)
Changed: branch: master-1.12
Repository: wireshark

Commits:

c59e0a8 by Guy Harris (guy@xxxxxxxxxxxx):

    Do bounds checking when decompressing WCP packets.
    
    Extract the data offset and count only once, and make sure we don't run
    past the end of the data we've copied from the packet; have
    decompressed_entry() just do the decompression, rather than also
    fetching the data offset and count.
    
    Add some comments while we're at it.
    
    Bug: 10844
    Change-Id: I2dc2f9594422ffa8f15fd5c57c9dac2e30e363f4
    Reviewed-on: https://code.wireshark.org/review/6514
    Reviewed-by: Guy Harris <guy@xxxxxxxxxxxx>
    (cherry picked from commit b204ff4846fe84b7789893c6b1d9afbdecac5b5d)
    Reviewed-on: https://code.wireshark.org/review/6515
    

Actions performed:

    from  8963e36   Use the GTK+ 2 name for VoidSymbol.
    adds  c59e0a8   Do bounds checking when decompressing WCP packets.


Summary of changes:
 epan/dissectors/packet-wcp.c |  116 +++++++++++++++++++++++++++++-------------
 1 file changed, 82 insertions(+), 34 deletions(-)