Wireshark-commits: [Wireshark-commits] master fdd6554: Rename the FT_BYTES separator types to SEP_
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Sun, 11 Jan 2015 00:27:32 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=fdd6554ccd1b01554865323045033db9ca858f97
Submitter: Guy Harris (guy@xxxxxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

fdd6554 by Guy Harris (guy@xxxxxxxxxxxx):

    Rename the FT_BYTES separator types to SEP_ from BASE_.
    
    There's no requirement for "display" field values to have names
    beginning with BASE_; use SEP_, to indicate that they're separators.
    
    (And, yes, we should introduce SEP_NONE, with a value of 0, and use it.)
    
    While we're at it, fix BASE_SEMICOLON - the separator is a colon, not a
    semicolon - and document SEP_SPACE in doc/README.dissector.
    
    Change-Id: I856aafda2c60b8320dffe287f0deb06a9604a2bf
    Reviewed-on: https://code.wireshark.org/review/6486
    Reviewed-by: Guy Harris <guy@xxxxxxxxxxxx>
    

Actions performed:

    from  b4f5b6e   Update CMake "Project names" and Folders
    adds  fdd6554   Rename the FT_BYTES separator types to SEP_ from BASE_.


Summary of changes:
 doc/README.dissector                      |    4 ++--
 epan/dissectors/packet-fc.c               |    6 +++---
 epan/dissectors/packet-fcdns.c            |    8 ++++----
 epan/dissectors/packet-fcels.c            |   14 +++++++-------
 epan/dissectors/packet-fcfcs.c            |    2 +-
 epan/dissectors/packet-fcfzs.c            |    2 +-
 epan/dissectors/packet-fcsb3.c            |    2 +-
 epan/dissectors/packet-fcswils.c          |    8 ++++----
 epan/dissectors/packet-fip.c              |    4 ++--
 epan/dissectors/packet-isis-hello.c       |    2 +-
 epan/dissectors/packet-mip6.c             |    2 +-
 epan/dissectors/packet-ppp.c              |    2 +-
 epan/dissectors/packet-zbee-zcl-general.c |    4 ++--
 epan/dissectors/packet-zbee-zcl-ha.c      |    2 +-
 epan/dissectors/packet-zbee-zcl.c         |    2 +-
 epan/ftypes/ftype-bytes.c                 |    8 ++++----
 epan/proto.c                              |   26 +++++++++++++-------------
 epan/proto.h                              |    8 ++++----
 18 files changed, 53 insertions(+), 53 deletions(-)