Wireshark-commits: [Wireshark-commits] lts-1.12.1 1c14dd9: LPP: avoid doing an out of bound access
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Fri, 9 Jan 2015 15:36:56 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=1c14dd927d4db6d65522e190ca88e2580f59c0fb
Submitter: Balint Reczey (balint@xxxxxxxxxxxxxxx)
Changed: branch: lts-1.12.1
Repository: wireshark

Commits:

1c14dd9 by Pascal Quantin (pascal.quantin@xxxxxxxxx):

    LPP: avoid doing an out of bound access in case the PER decoding gives an invalid value
    
    Bug: 10773
    Change-Id: I4fcde84d7be1e42729b6ec0763064e9885951468
    Reviewed-on: https://code.wireshark.org/review/5729
    Reviewed-by: Pascal Quantin <pascal.quantin@xxxxxxxxx>
    (cherry picked from commit 8e96830156bea314207b97315ccebd605317f142)
    Reviewed-on: https://code.wireshark.org/review/5730
    (cherry picked from commit edc1a29b9efe9e4298a80550ac71a78abc8f0511)
    Reviewed-on: https://code.wireshark.org/review/6426
    Reviewed-by: Balint Reczey <balint@xxxxxxxxxxxxxxx>
    

Actions performed:

    from  f4f1199   Make sure we don't underrun a buffer when decrypting SSL.
    adds  1c14dd9   LPP: avoid doing an out of bound access in case the PER decoding gives an invalid value


Summary of changes:
 asn1/lpp/lpp.cnf             |    4 +-
 epan/dissectors/packet-lpp.c |  144 +++++++++++++++++++++---------------------
 2 files changed, 76 insertions(+), 72 deletions(-)