Wireshark-commits: [Wireshark-commits] master 4088a82: SET_ADDRESS -> TVB_SET_ADDRESS to "hide" som
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Wed, 7 Jan 2015 12:37:56 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=4088a8286d9e2dfd8f2b1c316472d768cbefec8e
Submitter: Michael Mann (mmann78@xxxxxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

4088a82 by Michael Mann (mmann78@xxxxxxxxxxxx):

    SET_ADDRESS -> TVB_SET_ADDRESS to "hide" some of the tvb_get_ptr use.
    
    Not all changes were able to remove their corresponding tvb_get_ptr, because there are other API dependent on the (tvb_get)pointer, but future iterations optimizing those other APIs will then be able to remove it.
    
    Change-Id: Id7cefd440b81834de1d1aace7cd0789b1c871a22
    Reviewed-on: https://code.wireshark.org/review/6358
    Petri-Dish: Michael Mann <mmann78@xxxxxxxxxxxx>
    Tested-by: Petri Dish Buildbot <buildbot-no-reply@xxxxxxxxxxxxx>
    Reviewed-by: Michael Mann <mmann78@xxxxxxxxxxxx>
    

Actions performed:

    from  6252074   DJIUAV: small cleanups
    adds  4088a82   SET_ADDRESS -> TVB_SET_ADDRESS to "hide" some of the tvb_get_ptr use.


Summary of changes:
 epan/dissectors/packet-ap1394.c       |   15 +-
 epan/dissectors/packet-ax25.c         |   10 +-
 epan/dissectors/packet-bat.c          |   23 +--
 epan/dissectors/packet-batadv.c       |  352 +++++++++++++++------------------
 epan/dissectors/packet-btbnep.c       |   32 ++-
 epan/dissectors/packet-clnp.c         |   12 +-
 epan/dissectors/packet-eth.c          |   12 +-
 epan/dissectors/packet-exported_pdu.c |   21 +-
 epan/dissectors/packet-infiniband.c   |   32 +--
 epan/dissectors/packet-ip.c           |   15 +-
 epan/dissectors/packet-ipx.c          |   17 +-
 epan/dissectors/packet-netrom.c       |   10 +-
 epan/dissectors/packet-p_mul.c        |   14 +-
 epan/dissectors/packet-sll.c          |   25 +--
 epan/dissectors/packet-sna.c          |   29 +--
 epan/dissectors/packet-tipc.c         |   34 ++--
 epan/dissectors/packet-vines.c        |   11 +-
 17 files changed, 267 insertions(+), 397 deletions(-)