Wireshark-commits: [Wireshark-commits] master-1.12 29e1f73: Revert "[PROFINET] Fix swapped Maintena
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Tue, 6 Jan 2015 10:12:25 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=29e1f73b9421d022395badfd7021d07f3022a607
Submitter: Pascal Quantin (pascal.quantin@xxxxxxxxx)
Changed: branch: master-1.12
Repository: wireshark

Commits:

29e1f73 by Anish Bhatt (anish@xxxxxxxxxxx):

    Revert "[PROFINET] Fix swapped MaintenanceRequired & MaintenanceDemanded bits"
    
    This reverts commit 0452f763fb0dd2cf7e38f0a127c306199a814c3e. Changes should
    have been made in ChannelProperties instead of Submodule state. Current
    implementation merely *appears* to be correct as we are reading it as a two bit
    value but instead should be addressing it as individual bits, little endian
    Bug: 10753
    
    Change-Id: Ia3bd088aeb376b8511d64352f62c4304e4129ba6
    Reviewed-on: https://code.wireshark.org/review/6334
    Reviewed-by: Alexis La Goutte <alexis.lagoutte@xxxxxxxxx>
    (cherry picked from commit eb98b04ac12efe01d1abddf866b18f31101533ee)
    Reviewed-on: https://code.wireshark.org/review/6339
    Reviewed-by: Pascal Quantin <pascal.quantin@xxxxxxxxx>
    

Actions performed:

    from  f5e435a   Make sure we don't underrun a buffer when decrypting SSL.
    adds  29e1f73   Revert "[PROFINET] Fix swapped MaintenanceRequired & MaintenanceDemanded bits"


Summary of changes:
 plugins/profinet/packet-dcerpc-pn-io.c |   16 ++++++++--------
 1 file changed, 8 insertions(+), 8 deletions(-)