Wireshark-commits: [Wireshark-commits] master 5653fce: No *pcap should have pcap_open() without the
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Sun, 4 Jan 2015 20:59:18 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=5653fcedca8491829d6d6ce480e7fba13ff801d7
Submitter: Guy Harris (guy@xxxxxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

5653fce by Guy Harris (guy@xxxxxxxxxxxx):

    No *pcap should have pcap_open() without the other remote extensions.
    
    WinPcap 3.0 introduced pcap_open(); it also introduced
    pcap_findalldevs_ex() and pcap_createsrcstr().  If you're going to put
    pcap_open() in libpcap, there's not much point to doing so but not also
    putting pcap_findalldevs_ex() and pcap_createsrcstr() there.
    
    (And, in the future, there'll be support for remote capturing with
    pcap_create() and pcap_activate(), with no need for pcap_createsrcstr(),
    and a replacement for pcap_findalldevs() and pcap_findalldevs_ex(),
    which we'll also check for.)
    
    So there's no need to check for pcap_findalldevs_ex() or
    pcap_createsrcstr().
    
    Change-Id: I9323aad20136684d05d1e909326792a2f1408887
    Reviewed-on: https://code.wireshark.org/review/6311
    Reviewed-by: Guy Harris <guy@xxxxxxxxxxxx>
    

Actions performed:

    from  9aeb249   ACSE: get rid of an evil global variable
    adds  5653fce   No *pcap should have pcap_open() without the other remote extensions.


Summary of changes:
 acinclude.m4                 |    6 ++----
 cmake/modules/FindPCAP.cmake |    4 +---
 2 files changed, 3 insertions(+), 7 deletions(-)