Wireshark-commits: [Wireshark-commits] master ff01bc6: gtk: fix crash when moving columns
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Sun, 4 Jan 2015 16:46:55 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=ff01bc6c4e0b07a95016fde9c1ff25aaf56585eb
Submitter: Pascal Quantin (pascal.quantin@xxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

ff01bc6 by Peter Wu (peter@xxxxxxxxxxxxx):

    gtk: fix crash when moving columns
    
    When the columns are moved, the packet list is redrawn from the
    columns-changed signal handler. Apparently GTK does not like that the
    parent contains got destroyed.
    
    Call packet_list_recreate outside the callback to workaround this issue.
    Since the signal handler is blocked, it can never be called twice (and
    there will always be at most one packet_list_recreate_delayed
    scheduled).
    
    Bug: 10795
    Change-Id: Ia97d330c8bef747809fa09a8709a19cb03c7e00a
    Reviewed-on: https://code.wireshark.org/review/5881
    Reviewed-by: Alexis La Goutte <alexis.lagoutte@xxxxxxxxx>
    Reviewed-by: Pascal Quantin <pascal.quantin@xxxxxxxxx>
    

Actions performed:

    from  553da37   Create BASE_DOT, BASE_DASH, and BASE_SEMICOLON types for the FT_BYTES field type.
    adds  ff01bc6   gtk: fix crash when moving columns


Summary of changes:
 ui/gtk/packet_list.c |   10 +++++++++-
 1 file changed, 9 insertions(+), 1 deletion(-)